Skip to content
This repository was archived by the owner on Jan 1, 2020. It is now read-only.

[WIP] Twig extension testing, fix nontype collections #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Twig extension testing, fix nontype collections #43

wants to merge 3 commits into from

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Dec 16, 2012

this tries to address #37

unfortunately, i still don't know how to really handle string tags and would need somebody to experiment with the minimum required thing to use the createjs tag plugin for them and see if we can inline such tags with the main entity in some way or not.

@flack
Copy link
Collaborator

flack commented Dec 17, 2012

Hi,

just a quick comment: travis says the tests fail for this because some doctrine stuff can't be found:

PHP Fatal error:  Class 'Doctrine\Common\Annotations\AnnotationRegistry' not found in /home/travis/builds/flack/createphp/tests/Test/Midgard/CreatePHP/Extension/Twig/CreatephpExtensionTest.php on line 40

so it seems composer.json or something has to be updated. I wonder if composer supports conditional dependencies, but well, for the moment we can make do with the dev switch

@dbu
Copy link
Collaborator Author

dbu commented Dec 17, 2012

yes, would be a typical case for --dev. the optional stuff is handled with suggest and up to the user whether he wants to include suggestions in his main composer.json.

i will investigate this when i find time again to work on it, not sure how soon that can happen.

@dbu
Copy link
Collaborator Author

dbu commented Jan 17, 2013

what is done here is fixed in #46 too. the only issue are the nontype collections of tags where i still miss an example of how the tag plugin of create.js works

@flack
Copy link
Collaborator

flack commented Feb 4, 2013

@dbu: I'm not really sure I understand your last comment. Do you mean to say that this is superseded by #46? If so, can I close this PR? Travis shows 3 errors and one failure for it right now, but different ones than when I made my last comment, so there seems to be some progress :-)

@dbu
Copy link
Collaborator Author

dbu commented Feb 14, 2013

i will update this branch once #46 has been merged and see what is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants