Combine sweeps from multiple radar volumes or single scans into a single volume #306
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 93.50% 93.54% +0.04%
==========================================
Files 27 27
Lines 5555 5580 +25
==========================================
+ Hits 5194 5220 +26
+ Misses 361 360 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kmuehlbauer
left a comment
kmuehlbauer
left a comment
There was a problem hiding this comment.
This is looking good to me. Would be great, if we also can work with simple Dataset objects instead of DataTree.
| Sweeps are sorted by their start time to ensure temporal consistency. | ||
| Parameters: | ||
| volumes: List of DataTree objects, each representing a radar volume or a single scan. |
There was a problem hiding this comment.
Wouldn't it make sense to make this work for multiple sweep Dataset objects, too?
Use case would be single sweeps opened by xr.open_dataset.
Should be possible when looking at the code, but nor sure how much involved that would be.
There was a problem hiding this comment.
Why is open_dataset not always returning a DataTree with mandatory global variables?
There was a problem hiding this comment.
Because it opens a Dataset, not a DataTree. If we want to get back a DataTree we would have to use open_datatree, but that's not implemented in the xradar backends AFAICT. We currently only have a dedicated open_"backend"_datatree function.
The issue is that our DataTree implementation was made before DataTree was finally introduced into xarray codebase.
|
It is not clear to me how you can retrieve the global metadata from the sweep datasets. The DataTree seems to be the natural object for implementing FM301. The approach has been refined in #307 with some extra motivation. |
2 participants
No description provided.