fix: add publishConfig for scoped packages #97
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoped npm packages require explicit public access configuration when using newer granular access tokens. This fixes the E404 error when publishing to npm. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace lerna publish with npm publish --workspaces to properly support OIDC/Trusted Publishers authentication. Each workspace is published separately with error handling to allow partial publishes when some versions already exist. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the publishing workflow and configuration for the npm packages, focusing on improving security, compatibility, and reliability. The main changes include upgrading the Node.js version, switching to OIDC authentication for publishing, updating the publish scripts, and ensuring both packages are configured for public access.
The problem is that classic tokens were revoked. So I decided to use OIDC for authentication.
Workflow and authentication improvements:
.github/workflows/publish.yml) to use OIDC authentication for publishing to npm, replacing the previous token-based method. This enhances security and aligns with best practices.18.xto24for better compatibility and support.Publishing configuration and scripts:
npm-publishscript inpackage.jsonto publish both@openreview/clientand@openreview/meta-extractionpackages individually with provenance and public access flags, improving reliability and transparency of the publishing process.publishConfigwith"access": "public"to bothpackages/client/package.jsonandpackages/meta-extraction/package.jsonto ensure the packages are published as public on npm. [1] [2]