Skip to content

create metric invitation and compute stats for the venue #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

melisabok
Copy link
Member

No description provided.

Comment on lines 1476 to 1486
self.client.delete_edges(invitation=f'{reviewers_id}/-/Review_Assignment_Count', wait_to_finish=True, soft_delete=True)
openreview.tools.post_bulk_edges(self.client, review_assignment_count_edges)

self.client.delete_edges(invitation=f'{reviewers_id}/-/Review_Count', wait_to_finish=True, soft_delete=True)
openreview.tools.post_bulk_edges(self.client, review_count_edges)

self.client.delete_edges(invitation=f'{reviewers_id}/-/Discussion_Reply_Sum', wait_to_finish=True, soft_delete=True)
openreview.tools.post_bulk_edges(self.client, comment_count_edges)

self.client.delete_edges(invitation=f'{reviewers_id}/-/Review_Days_Late_Sum', wait_to_finish=True, soft_delete=True)
openreview.tools.post_bulk_edges(self.client, review_days_late_edges)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be moved outside the assignments_by_reviewers loop right? So we aren't deleting and posting all the edges every time we loop through a reviewer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhh yes, thanks

Comment on lines 1377 to 1379

all_anon_reviewer_groups = [g for g in all_submission_groups if '/Reviewer_' in g.id ]
all_anon_reviewer_group_members = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Reviewer_ can be replaced with the Reviewers group name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change it to use "venue.anon_reviewers_name"?

Comment on lines 1386 to 1388
for g in all_anon_reviewer_groups:
profile = profile_by_id.get(g.members[0])
if profile:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there are no users in the anon group and g.members[0] will error. I'm not sure when this happens, maybe when there's an undeployment or unassignment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix it and push the change here?

@carlosmondra
Copy link
Member

I have posted some changes so that it uses tags instead of edges. However, it requires the following PR to be merged for the tests to pass: https://github.com/openreview/openreview-api/pull/754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants