Feat: Change comment readers when comment is deleted #2438
Conversation
| @@ -16,6 +16,20 @@ def process(client, edit, invitation): | |||
| comment = client.get_note(edit.note.id) | |||
| paper_group_id=f'{venue_id}/{submission_name}{submission.number}' | |||
|
|
|||
| # Change comment readers to be only the author if the comment is deleted | |||
| # Domain admins can still see the comment | |||
| if comment.ddate: | |||
There was a problem hiding this comment.
why do you need to do this? could you please add a test for this?
There was a problem hiding this comment.
I updated the description of the PR. I don't have a complete solution for it, but I am willing to discuss alternatives.
There was a problem hiding this comment.
Thanks, what about making the edits not accesible if the note is deleted? I guess this can happen with other type of notes not only comments.
There was a problem hiding this comment.
How do we make them not accessible? Do you mean in the backend? How do we do that? If we use ddate, what happens if a user passes trash=true?
There was a problem hiding this comment.
I was thinking that only the owner of the note can see the edits if the note is deleted.
This PR shows a possible solution to the following problem:
When a comment is deleted, the readers of the comment remain unchanged. That means that the UI still renders the deleted comment because the param
trash=trueis also passed. The problem is that the revisions link is still visible and the edits remain accessible. One option is to change the readers of the comment so that the deleted Note does not appear for everyone. It is still unclear how the readers will be restored if the Note is restored. Also, I am not sure if the edits' readers should change or just hiding the revisions link is sufficient.More context here: https://secure.helpscout.net/conversation/2773317204/1708