Feat/ Venue Config: refactor + AC workflow #2579
Conversation
| def set_reviewers_only_comment(self): | ||
|
|
||
| support_group_id = self.support_group_id | ||
| comment_invitation_id = f'{support_group_id}/Venue_Request/Reviewers_Only/-/Comment' |
There was a problem hiding this comment.
this invitation seems to be very similar to all the workflow requests, can we use one invitation for all requests? same as the deployment invitation.
There was a problem hiding this comment.
I am not sure about using the same deployment invitation, because each workflow will have its own deployment process.
I can make the change for the comment invitation now.
There was a problem hiding this comment.
I suggest using the same code to create the invitation and parametrie the name of the process function?
|
| @@ -0,0 +1,57 @@ | |||
| def process(client, edit, invitation): | |||
There was a problem hiding this comment.
this is something that I would like to refactor to be the same for any group that we want to create that requires messaging and recruitment.
| @@ -13,10 +13,14 @@ def process(client, edit, invitation): | |||
| if edit.id != note_edits[0].id: | |||
| print('not first edit, exiting...') | |||
| return | |||
|
|
|||
There was a problem hiding this comment.
I would move this file outside of the workflows folder. Maybe another folder?
…py into feat/acs-workflow
…ubmission groups, update PC_Revision
…py into feat/acs-workflow
| @@ -31,6 +31,9 @@ def get_venue(client, venue_id, support_user='OpenReview.net/Support'): | |||
| venue.allow_gurobi_solver = domain.content.get('allow_gurobi_solver', {}).get('value', False) | |||
| venue.preferred_emails_groups = domain.content.get('preferred_emails_groups', []) | |||
|
|
|||
| venue.submission_stage = openreview.stages.SubmissionStage( | |||
There was a problem hiding this comment.
@melisabok Using the venue code to upload decisions works, but I had to add the submission_stage here. submission_stage.name is used when we call get_paper_group_prefix() to get the paper decision invitation. Is there a better way to do this?
There was a problem hiding this comment.
yes, it is great! then all the code will work, a lot of places call to venue.submission_stage so I think setting this up in the get_venue function seems correct. We should do the same for other stages if needed
| @@ -277,6 +286,9 @@ def create_venue_group(self): | |||
| if self.venue.request_form_id: | |||
| content['request_form_id'] = { 'value': self.venue.request_form_id } | |||
|
|
|||
| if self.venue.request_form_invitation: | |||
| content['request_form_invitation'] = { 'value': self.venue.request_form_invitation } | |||
There was a problem hiding this comment.
@xkopenreview is this keyword exists then the venue is running on the new workflow configuration
| @@ -0,0 +1,104 @@ | |||
| def process(client, edit, invitation): | |||
No description provided.