Assignment Quotas: Fix race condition #2586
Open
+102
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
May 28, 2025
| @@ -31,7 +31,7 @@ async function process(client, edge, invitation) { | |||
| // Filter invite assignment edges to exclude edges that are accepted | |||
| const filteredInviteAssignmentEdges = inviteAssignmentEdges.filter(e => !filteredLabels.includes(e?.label ?? '')) | |||
|
|
|||
| if (quota && filteredInviteAssignmentEdges.length + filteredAssignmentEdges.length >= quota) { | |||
| if (quota && filteredInviteAssignmentEdges.length + filteredAssignmentEdges.length >= quota + 1) { | |||
There was a problem hiding this comment.
if you relax this validation, all the papers can have quota + 1 assignments, is this what we want?
There was a problem hiding this comment.
There are two options to solve this:
- Reject the assignment for the invited reviewer that accepted the invitation. Send an email saying the paper already has enough reviewers and their review is not needed anymore.
- Bypass the validation here by checking that if that assignment is coming from an invite assignment then let it post the edge. You can check that is the edge that we are trying to post already exists as an invite assignment (same head and tail) then we let the edge to be posted. As a summary: only check the quota when the assignment edge doesn't come from an invite assignment.
There was a problem hiding this comment.
@haroldrubio any updates on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix to the assignment/invite assignment quota caused by a delay in inserting data into Mongo. This delay adds a race condition where two invites get sent out while receiving outdated information on the number of assignments to a paper. For example, 2 assignments are already made, and 2 invite assignment requests are made quickly. Only one of these should post but both of these will post causing errors in any subsequent assignments to that paper.
The fix: