Skip to content

Journal: use stream true to load all the invitations, notes and groups #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

melisabok
Copy link
Member

No description provided.

@@ -175,10 +175,10 @@ var loadData = function() {
Webfield2.api.getGroupsByNumber(VENUE_ID, ACTION_EDITOR_NAME),
Webfield2.api.getGroupsByNumber(VENUE_ID, REVIEWERS_NAME, { withProfiles: true}),
Webfield2.api.getAllSubmissions(SUBMISSION_ID, { domain: VENUE_ID }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about getAllSubmissions
it calls getAll('/notes', query)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAllSubmissions adds the details param so we can not use stream=true here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change will be in webfield2.js
from getall('/notes to get('/notes and add stream true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed this in the daily meeting
when getAllSubmissions request for details then stream won't work
so leave it as it is now

@xkopenreview
Copy link
Contributor

is this change making the eic console to load faster?
i didn't really feel the difference in loading time

@melisabok
Copy link
Member Author

is this change making the eic console to load faster?

I don't see any different, you are right but @carlosmondra found slow queries coming from this console.

@xkopenreview xkopenreview merged commit dfd8494 into master Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants