-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/ Notification search #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
currently there's no unit tests or integration tests for notification page which is not good |
So this PR makes a search on all messages using subject prefix? I feel like most people will expect to be a search over any part of the text. Is this related to an issue we are trying to fix? |
related to openreview/openreview#201 to filter messages from certain venue |
Wouldn't it be easier to use the domain keyword? |
i think there's no domain keyword |
@xkopenreview can we do a local search? we currently load all the messages in the notifications page, let's do the search using the loaded messages, no need to call the api |
i think it only loads 25 messages of the first page |
when the user is involved in many conferences, it's hard to check the notifications from a certain conference.
this pr should add the search input in notifications page so that user can search the email subject