-
Notifications
You must be signed in to change notification settings - Fork 6
Fix/ AC Console - Show assigned secondary AC(s) #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
this pr does not require any change for next upgrade |
.get( | ||
'/edges', | ||
{ | ||
invitation: `${venueId}/${secondaryAreaChairName}/-/Assignment`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to pass the whole invitation id in the property of the component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xkopenreview I left a comment here
@xkopenreview do you have a screenshot for this? I want to check if there is a "Copy Email" link in the secondary area chair info. |
there's no copy email link |
I don't understand this change. Why an AC has assigned a Secondary AC? |
So we create this invitation:
And each triplet member has an assignment edge to each other? |
Before merging this PR, I do suggest to prepare the workflow where this is needed. Make sure we have a test in openreview-py that support triplets and they need to be shown in the AC console. |
What do you mean by this? Do you mean making changes in openreview-py so it creates this invitation? Maybe if |
I don't think all the venues with secondary area chairs will have this assignment. I think this is a feature related to CVPR/ICCV venues where they have triplets. My suggestion is to create the assignment invitation in the test where we are testing triplets and go from there. |
this pr should show in AC console the secondary AC(s) contact info.
similar to assigned SAC info
it assumes the invitation to create the secondary assignment edge is
{venue_id}/{secondary_area_chairs_name}/-/Assignment