Skip to content

Fix/ AC Console - Show assigned secondary AC(s) #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

this pr should show in AC console the secondary AC(s) contact info.
similar to assigned SAC info

it assumes the invitation to create the secondary assignment edge is
{venue_id}/{secondary_area_chairs_name}/-/Assignment

@xkopenreview xkopenreview marked this pull request as ready for review December 19, 2024 14:05
@xkopenreview
Copy link
Collaborator Author

this pr does not require any change for next upgrade

.get(
'/edges',
{
invitation: `${venueId}/${secondaryAreaChairName}/-/Assignment`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to pass the whole invitation id in the property of the component?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xkopenreview I left a comment here

@melisabok
Copy link
Member

@xkopenreview do you have a screenshot for this?

I want to check if there is a "Copy Email" link in the secondary area chair info.

@xkopenreview
Copy link
Collaborator Author

@xkopenreview do you have a screenshot for this?

I want to check if there is a "Copy Email" link in the secondary area chair info.

there's no copy email link
the call is made automatically and email is appended if the edge exist
image

@xkopenreview xkopenreview requested a review from melisabok May 6, 2025 16:18
@melisabok
Copy link
Member

I don't understand this change. Why an AC has assigned a Secondary AC?

@enrubio
Copy link
Member

enrubio commented May 7, 2025

So we create this invitation: {venue_id}/{secondary_area_chairs_name}/-/Assignment. Should the head & tail be this?:

"param": {
      "type": "profile",
      "options": {
        "group": "venue_id/Area_Chairs"
      }
    }

And each triplet member has an assignment edge to each other?

@melisabok
Copy link
Member

Before merging this PR, I do suggest to prepare the workflow where this is needed.

Make sure we have a test in openreview-py that support triplets and they need to be shown in the AC console.

@enrubio
Copy link
Member

enrubio commented May 7, 2025

suggest to prepare the workflow where this is needed

What do you mean by this? Do you mean making changes in openreview-py so it creates this invitation? Maybe if secondary_area_chairs is enabled in the request form we can create it.

@melisabok
Copy link
Member

I don't think all the venues with secondary area chairs will have this assignment. I think this is a feature related to CVPR/ICCV venues where they have triplets.

My suggestion is to create the assignment invitation in the test where we are testing triplets and go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants