Skip to content

Fix/ PC Console - cache data #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xkopenreview
Copy link
Collaborator

this pr should add a new config

useCache

to pc console config
when set to true, it should cache in browser indexed db most pc console data so that when user does not need latest data it can load faster.

when user access pc console, cache older than 24 hours are removed.

@melisabok
Copy link
Member

melisabok commented May 16, 2025

  1. Could we also include the timestamp of the last loaded data?
Screenshot 2025-05-16 at 11 28 48 AM
  1. it looks like the Console still do some API calls, to get the Invited groups, do you know why?
  2. The other tabs like "Reviewers Status" is also loading some data
  3. When clicking on "Reload", I think we should show a progress icon that shows that is loading otherwise it is hard to see what is happening.
  4. What about using the following label for the loaded data?

"Data cached 15 seconds ago"
"Last refreshed: [timestamp]"

I don't have too much data in my environment to test so I would like to merge this and test it with an old conference in the live site. What do you think?

@xkopenreview
Copy link
Collaborator Author

  1. it looks like the Console still do some API calls, to get the Invited groups, do you know why?
  2. The other tabs like "Reviewers Status" is also loading some data

the invited groups are for the invited group links in overview tab
reviewer status load reviewer profiles

compare to the notes data i think these data (<1M) does not really need to be cached

@melisabok
Copy link
Member

What about 1, 4 and 5, are you working on it?

@xkopenreview
Copy link
Collaborator Author

What about 1, 4 and 5, are you working on it?

please take a look at 1b12b4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants