Skip to content

Feature/ Workflow invitations on next.js 15 #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 202 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

Changes of #1952 on top of #2308

@xkopenreview
Copy link
Collaborator Author

@celestemartinez @melisabok
please use this branch when you are testing the venue config
let me know if anything is not working as expected in this branch

@xkopenreview
Copy link
Collaborator Author

d8c075b should:

  1. show "Configuration tasks pending" error message only when the sub invitation is a uncompleted task (with due date and step invitation has not been edited using the sub invitation)
  2. not to show an invitation as sub invitation if itself is also a step invitation
  3. json editor show json tab first
  4. move group edit invitations to tabs based on the field that they are editing

@xkopenreview
Copy link
Collaborator Author

@celestemartinez @melisabok
this is the pr to use for workflow invitations

@melisabok
Copy link
Member

Thanks Xukun. I realized that documentation site has a lot of examples to edit groups/invitations using the edit UI that we are hiding in this PR. Could it be possible to keep it visible only for venues that don't use the new workflow?

@xkopenreview
Copy link
Collaborator Author

efee25e should
show tab group editor only for venues using the new workflow

because of this change, group info page can't be removed otherwise non-writers (can't see group admin) of venues using old workflow will get stuck in redirections:

  • user access group edit
  • group edit redirect to group admin because venue is not using new workflow
  • user is not writer of group so group admin will redirect back to group edit (redirecting to group info will stop redirection)

@celestemartinez
Copy link
Member

Should we remove the link to the Workflow Configuration in the PC console if the venue doesn't use the new workflow?

Screenshot 2025-06-11 at 4 09 10 PM

@xkopenreview
Copy link
Collaborator Author

Should we remove the link to the Workflow Configuration in the PC console if the venue doesn't use the new workflow?

i think you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants