Remove email addresses from contributors and de-dupe them#212
Remove email addresses from contributors and de-dupe them#212
Conversation
| writeln("## Contributors\n") | ||
| // Extract unique contributor names (removing duplicates) | ||
| val uniqueNames = recipeDescriptor.contributors | ||
| .map { contributor -> contributor.name } |
There was a problem hiding this comment.
We might want to remove accents here as well:
https://www.baeldung.com/java-remove-accents-from-text
There was a problem hiding this comment.
Perhaps it would be better to already remove these accents in openrewrite/rewrite, just to avoid duplicating the logic in the platform.
There was a problem hiding this comment.
Now normalizing author names in openrewrite/rewrite-build-gradle-plugin@9343d65
We'll see if we need to make adjustments here, but I'd not expect so.
| val uniqueNames = recipeDescriptor.contributors | ||
| .map { contributor -> contributor.name } | ||
| .distinct() | ||
| .sorted() |
There was a problem hiding this comment.
The order or distinct & sorted matters, I think; distinct only removes duplicates that are next to each other.
Apart from that I would not change the order by sorting, as by default we sort by who has contributed the most lines of code(!), which I'd want to retain.
There was a problem hiding this comment.
My understanding is that distinct() removes all duplicates from the collection - not just ones next to each other.
Good call out on sorted - removed that.
There was a problem hiding this comment.
I've confirmed that distinct removes dupes from the whole collection by running and looking at the spring boot 3.5 recipe:
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
2 participants
No description provided.