Fix for ChangePackage being able to create ambiguous imports for types in use upon reparsing
#6535
+129
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g possible to parse again.
steve-aom-elliott
added
bug
timtebeek
reviewed
Jan 15, 2026
| @Test | ||
| void ambiguousImportIssue() { | ||
| rewriteRun( | ||
| spec -> spec.recipe(new ChangePackage("origpkg.validation", "newpkg.validation", true)), |
Member
There was a problem hiding this comment.
Looks like we had a similar PR posted with a potential fix:
Contributor
Author
There was a problem hiding this comment.
From the looks of that PR, that's just dealing with getting the name right. I think the issue here is not the names themselves but rather that if you change a package name, there may then be two potential sources for the same class, etc. that you are using in your code if you're referencing it in a not fully-qualified type of way.
… issue (#6058) * fix: ChangePackage from packageName is part of the submodule dir name issue ie: ``` submodule name: p1-core and ChangePackage from: p1.sub1-> to: p2.sub1 before this pr result -> p2-core/src/java/sub1/xx after this pr result -> p1-core/src/java/p2/sub1/xx ``` * fixup! fix: ChangePackage from packageName is part of the submodule dir name issue * Apply suggestions from code review --------- Co-authored-by: Tim te Beek <[email protected]> Co-authored-by: Tim te Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding simple test showcasing recipe not failing, but result not being possible to parse again.
What's changed?
What's your motivation?
Change package can result in type ambiguity upon reparsing, leading to compilation failures.
Checklist