Python: Fix various parser issues #6547
Merged
+4,483
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement parsing and printing for Python 3.12+ type parameters (TypeVar, TypeVarTuple, ParamSpec) in class and function definitions - Add support for subscript decorators (e.g., @[property][0]) - Fix f-string debug expression trailing newline issue - Add comprehensive tests for type parameters and decorators Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add support for PEP 695 type parameters on type alias statements (e.g., `type Foo[T] = list[T]`). Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Detect and strip BOM character (U+FEFF) before parsing - Store BOM presence in CompilationUnit.charset_bom_marked - Output BOM when printing if file originally had one Co-Authored-By: Claude Opus 4.5 <[email protected]>
The parser was incorrectly determining whether parentheses belong to a
tuple or its first element. The heuristic only checked column offset,
but for multi-line tuples like:
for (
window,
in_entry,
) in buf_out:
The tuple and first element have the same column offset (4) but are on
different lines. The fix now checks both line AND column to correctly
identify that the '(' belongs to the tuple itself.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds parser tests as Pytest modules, as these are way quicker to run (~200ms total).