-
Notifications
You must be signed in to change notification settings - Fork 499
Fix dependency management logic resolution order #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java
Outdated
Show resolved
Hide resolved
timtebeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, thanks! Couple quick suggestions, but otherwise looks ok to me.
sambsnyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Tim's feedback about the tests
timtebeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the research, fix and adjustments!
What's changed?
What's your motivation?
Encountered a diamond problem which illustrated an issue with managed dependency handling.
Anything in particular you'd like reviewers to focus on?
N/A
Anyone you would like to review specifically?
@timtebeek @sambsnyd
Have you considered any alternatives or workarounds?
N/A
Any additional context
I did clean up one extra test to be a bit more idiomatic with OpenRewrite standards.
Checklist