Reduce scope of recipe resolvers #6557
Open
+105
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces can be properly released
jkschneider
reviewed
Jan 16, 2026
rewrite-core/src/main/java/org/openrewrite/marketplace/RecipeBundleResolver.java
Outdated
Show resolved
Hide resolved
|
|
||
| public RecipeDescriptor describe() { | ||
| return resolve().describe(this); | ||
| public RecipeDescriptor describe(List<RecipeBundleResolver> resolvers) { |
Member
There was a problem hiding this comment.
Widen to Collection or Iterable I think
Contributor
Author
There was a problem hiding this comment.
I've widened this to Collection, so if we ever need to use some of the helpful methods at that level we can.
rewrite-core/src/test/java/org/openrewrite/rpc/RewriteRpcTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
RecipeListing#describeandRecipeListing#prepare.RecipeBundleResolverandRecipeBundleReadernow implementCloseable, so that they can release resources when no longer needed.What's your motivation?
RecipeBundleResolverinstances need to be closable so that resources can be releasedAnything in particular you'd like reviewers to focus on?
N/A
Anyone you would like to review specifically?
@jkschneider or delegate
Have you considered any alternatives or workarounds?
N/A
Any additional context
N/A
Checklist