Use intersection types for RightPadded/LeftPadded in JavaScript AST #6559
+1,840
−983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkschneider
force-pushed
the
jkschneider/js-flat-padding
branch
from
3e2632d to
648060e
Compare
This changes `RightPadded<T extends J>` and `LeftPadded<T extends J>` from wrapper objects with an `element` property to intersection types where the padded value IS the element with padding mixed in: - `RightPadded<T extends J>` = `T & RightPaddingMixin` - `LeftPadded<T extends J>` = `T & LeftPaddingMixin` This aligns the TypeScript model more closely with the Java model and simplifies property access (no more `.element` for J nodes). Key changes: - Updated type definitions in tree.ts for intersection-based padding - Fixed visitor methods to handle intersection types correctly - Added function overloads for visitLeftPadded/visitRightPadded with type-safe return types (primitives never return undefined) - Fixed unwrap() in comparator.ts for intersection types (parens.tree instead of parens.tree.element) - Added guards for missing padding in formatting methods - Fixed WhitespaceReconciler to use ID comparison instead of reference equality for stopAfter functionality - Added hasSameKind override in semantic comparator for void/undefined equivalence
jkschneider
force-pushed
the
jkschneider/js-flat-padding
branch
from
648060e to
5cd8271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RightPadded<T extends J>andLeftPadded<T extends J>from wrapper objects with an.elementproperty to intersection types where the padded value IS the element with padding mixed invisitLeftPadded/visitRightPaddedwith improved type safety (primitives never return undefined)unwrap()in comparator.ts for intersection typesWhitespaceReconcilerto use ID comparison forstopAfterfunctionalityhasSameKindoverride in semantic comparator for void/undefined equivalence