AddDependency: tests showing version update inconsistency with test sources#6963
Draft
Jenson3210 wants to merge 1 commit intomainfrom
Draft
AddDependency: tests showing version update inconsistency with test sources#6963Jenson3210 wants to merge 1 commit intomainfrom
Jenson3210 wants to merge 1 commit intomainfrom
Conversation
…source sets Two tests demonstrate that AddDependency with onlyIfUsing=null behaves differently depending on which source set is present: - existingDependencyUpdatedWithMainSources: with srcMainJava, an existing dependency (guava 29.0-jre) is correctly updated to 30.0-jre - existingDependencyNotUpdatedWithTestSourcesOnly: with only srcTestJava, the same dependency is NOT updated because the test/provided scope check (lines 243-250) matches on groupId + artifactId only without checking the version, causing an early return. The compile scope check (lines 228-239) does include a version check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddDependencywithonlyIfUsing=nullbehaves inconsistently depending on which source set is presentexistingDependencyUpdatedWithMainSources: withsrcMainJava, guava 29.0-jre is updated to 30.0-jreexistingDependencyNotUpdatedWithTestSourcesOnly: with onlysrcTestJava, guava stays at 29.0-jreThe root cause is that the test/provided scope early-return check (lines 243-250 of
AddDependency.java) matches on groupId + artifactId only, without checking the version. The compile scope check (lines 228-239) does include a version comparison, which allows the update to proceed.Test plan