Skip to content

Support changing properties in Maven profiles #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MBoegers wants to merge 2 commits into
base: main
Choose a base branch
from
+139 −1
Draft

Support changing properties in Maven profiles #7031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf5639
Add failing tests for ChangePropertyValue in Maven profiles
MBoegers Mar 18, 2026
4d9882d
Support changing properties in Maven profiles
MBoegers Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rewrite-maven/src/main/java/org/openrewrite/maven/ChangePropertyValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public Xml.Document visitDocument(Xml.Document document, ExecutionContext ctx) {

@Override
public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) {
if (isPropertyTag() && propertyName.equals(tag.getName()) &&
if ((isPropertyTag() || isProfilePropertyTag()) && propertyName.equals(tag.getName()) &&
!newValue.equals(tag.getValue().orElse(null))) {
doAfterVisit(new ChangeTagValueVisitor<>(tag, newValue));
maybeUpdateModel();
Expand Down
5 changes: 5 additions & 0 deletions rewrite-maven/src/main/java/org/openrewrite/maven/MavenVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class MavenVisitor<P> extends XmlVisitor<P> {
static final XPathMatcher MANAGED_DEPENDENCY_MATCHER = new XPathMatcher("/project/dependencyManagement/dependencies/dependency");
static final XPathMatcher PROFILE_MANAGED_DEPENDENCY_MATCHER = new XPathMatcher("/project/profiles/profile/dependencyManagement/dependencies/dependency");
static final XPathMatcher PROPERTY_MATCHER = new XPathMatcher("/project/properties/*");
static final XPathMatcher PROFILE_PROPERTY_MATCHER = new XPathMatcher("/project/profiles/profile/properties/*");
static final XPathMatcher PLUGIN_MATCHER = new XPathMatcher("//plugins/plugin");
static final XPathMatcher ANNOTATION_PROCESSORS_PATH_MATCHER = new XPathMatcher("//annotationProcessorPaths/path");
static final XPathMatcher MANAGED_PLUGIN_MATCHER = new XPathMatcher("//pluginManagement/plugins/plugin");
Expand Down Expand Up @@ -101,6 +102,10 @@ public boolean isPropertyTag() {
return PROPERTY_MATCHER.matches(getCursor());
}

public boolean isProfilePropertyTag() {
return PROFILE_PROPERTY_MATCHER.matches(getCursor());
}

public boolean isDependencyTag() {
return isTag("dependency") && DEPENDENCY_MATCHER.matches(getCursor());
}
Expand Down
133 changes: 133 additions & 0 deletions rewrite-maven/src/test/java/org/openrewrite/maven/ChangePropertyValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,139 @@ void changeExistingProperty() {
);
}

@Test
void changePropertyInProfile() {
rewriteRun(
spec -> spec.recipe(new ChangePropertyValue("sonar.host.url", "https://new-sonar.example.com", false, false)),
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>

<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>

<profiles>
<profile>
<id>sonar</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<sonar.host.url>http://old-sonar.example.com</sonar.host.url>
<java.version>21</java.version>
</properties>
</profile>
</profiles>
</project>
""",
"""
<project>
<modelVersion>4.0.0</modelVersion>

<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>

<profiles>
<profile>
<id>sonar</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<sonar.host.url>https://new-sonar.example.com</sonar.host.url>
<java.version>21</java.version>
</properties>
</profile>
</profiles>
</project>
"""
)
);
}

@Test
void changePropertyInBothProjectAndProfile() {
rewriteRun(
spec -> spec.recipe(new ChangePropertyValue("java.version", "21", false, false)),
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>

<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>

<properties>
<java.version>17</java.version>
</properties>

<profiles>
<profile>
<id>sonar</id>
<properties>
<java.version>17</java.version>
</properties>
</profile>
</profiles>
</project>
""",
"""
<project>
<modelVersion>4.0.0</modelVersion>

<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>

<properties>
<java.version>21</java.version>
</properties>

<profiles>
<profile>
<id>sonar</id>
<properties>
<java.version>21</java.version>
</properties>
</profile>
</profiles>
</project>
"""
)
);
}

@Test
void doNotChangeUnrelatedPropertyInProfile() {
rewriteRun(
spec -> spec.recipe(new ChangePropertyValue("sonar.host.url", "https://new-sonar.example.com", false, false)),
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>

<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>

<profiles>
<profile>
<id>sonar</id>
<properties>
<java.version>21</java.version>
</properties>
</profile>
</profiles>
</project>
"""
)
);
}

@Test
void addPropertyInOrder() {
rewriteRun(
Expand Down