Use list protocol for ConditionalDirective.directiveLines in RPC#7081
Draft
knutwannheden wants to merge 1 commit intomainfrom
Draft
Use list protocol for ConditionalDirective.directiveLines in RPC#7081knutwannheden wants to merge 1 commit intomainfrom
knutwannheden wants to merge 1 commit intomainfrom
Conversation
DirectiveLines were sent/received using a manual count+loop pattern instead of the standard getAndSendList/receiveList protocol. This is the same class of bug fixed for ExceptionFilteredTry catch filters — while not currently broken (the count was sent explicitly), it bypasses the list protocol's position-matching and is fragile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConditionalDirective.directiveLineswas sent/received using a manual count+loop pattern instead ofgetAndSendList/receiveListExceptionFilteredTrycatch filters in RPC #7080 (ExceptionFilteredTry catch filters) — bypasses the list protocol's position-matchinglineNumberas the list element identityTest plan
CSharpRecipeTesttests pass