ChangeType: visit annotations on package declarations#7086
Open
ChangeType: visit annotations on package declarations#7086
Conversation
…Package Fixes an issue where fully-qualified annotations on package declarations in package-info.java files were not being visited by ChangeType's visitor.
timtebeek
commented
Mar 20, 2026
Comment on lines
+418
to
+430
| spec -> spec.recipe(new ChangeType("a.b.c.A1", "a.b.d.A2", true)), | ||
| java("package a.b.c;\npublic @interface A1 {}"), | ||
| java("package a.b.d;\npublic @interface A2 {}"), | ||
| java( | ||
| """ | ||
| @a.b.c.A1 package foo; | ||
| """, | ||
| """ | ||
| @A2 package foo; | ||
|
|
||
| import a.b.d.A2; | ||
| """, | ||
| spec -> spec.path("foo/package-info.java") |
Member
Author
There was a problem hiding this comment.
In all honesty we saw this test pass even when the main code change was rolled back, but the change makes sense, and I suspect it's to do with our testing framework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call
super.visitPackage(pkg, ctx)instead of returningpkgdirectly inJavaChangeTypeVisitor.visitPackage(), ensuring annotations on package declarations are properly visited during type changesAdd test for
ChangeTypewith a fully-qualified annotation on a package declaration inpackage-info.javaCloses Java migration in package-info.java files are not working rewrite-migrate-java#1018