Fix SSTI vulnerability in FreemarkerTemplateEngine and add security #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why are you doing a new PR instead of updating the first? |
Member
|
CI build not working (compilation problem). |
angelozerr
reviewed
Oct 23, 2025
integrationtests/.project
Outdated
| <natures> | ||
| <nature>org.eclipse.m2e.core.maven2Nature</nature> | ||
| </natures> | ||
| <filteredResources> |
Member
There was a problem hiding this comment.
Why you need this change? Please remove it.
angelozerr
reviewed
Oct 23, 2025
| @@ -0,0 +1,217 @@ | |||
| /** | |||
| * Copyright (C) 2011-2015 The XDocReport Team <[email protected]> | |||
Member
|
Your PR read the template and convert to a String and uses matches to check is it exists some pattern, which is very bad for performance. The Reader must read just one time to parse the template and not to check some used pattern. More those pattern are declared by the user so I don't see any value to check that. |
AT190510-Cuong
force-pushed
the
fix/ssti_new
branch
from
34458a3 to
4841df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add security validation to FreemarkerTemplateEngine to prevent SSTI
This patch introduces a validation step before processing Freemarker templates
to detect and block potentially dangerous expressions that could lead to
Server-Side Template Injection (SSTI).
Specifically, the new
validateTemplateSecurity()method scans the templatecontent for forbidden patterns such as:
If any of these are detected, an XDocReportException is thrown to stop template
execution.
This fix does not change normal template rendering behavior and remains fully
backward compatible for safe templates.