Skip to content

Alignment with slop #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025
Merged

Alignment with slop #65

merged 8 commits into from
Jun 11, 2025

Conversation

jbothma
Copy link
Contributor

@jbothma jbothma commented Jun 6, 2025

No description provided.

@pudo
Copy link
Member

pudo commented Jun 11, 2025

@jbothma Do you have a word on what needs to still be done here before this can be included as a next iteration?

@jbothma
Copy link
Contributor Author

jbothma commented Jun 11, 2025

I think there are cases with longer words where a short phrase might get picked when a longer phrase could be an option but the aligning bit is beyond slop.

Something like
a b c d e f g
b a f g

Alignment: a
Ideal: f g

Not sure this captures it but maybe you get the idea. Not 100% sure this really happens or is really a problem. If it's a corner case you can live with, you can merge.

@pudo
Copy link
Member

pudo commented Jun 11, 2025

Honestly I think this is a ten-year problem in the end, something we just build more and more and more test cases around. Let's maybe make a tracking issue soon once we see first failures.

@pudo pudo marked this pull request as ready for review June 11, 2025 08:41
@pudo pudo merged commit 3113865 into main Jun 11, 2025
3 checks passed
@pudo pudo deleted the alignment-with-slop branch June 11, 2025 08:55
@pudo
Copy link
Member

pudo commented Jun 11, 2025

Having a more detailed read now, this is a really nice implementation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants