Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

WIP: feat: add pnpm support#302

Open
williamfzc wants to merge 2 commits intoopensbom-generator:mainfrom
williamfzc:main
Open

WIP: feat: add pnpm support#302
williamfzc wants to merge 2 commits intoopensbom-generator:mainfrom
williamfzc:main

Conversation

@williamfzc
Copy link
Copy Markdown

@ba11b0y
Copy link
Copy Markdown
Contributor

ba11b0y commented Aug 22, 2023

Hey @williamfzc
Thanks for the PR!
We're trying to revamp this project to use the parsers project.

@williamfzc
Copy link
Copy Markdown
Author

williamfzc commented Aug 22, 2023

Hey @williamfzc Thanks for the PR! We're trying to revamp this project to use the parsers project.

Looks great, but what should I do next?
I notice that pkg/modules still keeps lots of duplicated code which same as the parser.

Maybe I should create another PR in parsers first? :)

@ba11b0y
Copy link
Copy Markdown
Contributor

ba11b0y commented Aug 22, 2023

Yes. Once the parser is good enough you can register it here

And then you can try your parser with the new command introduced here because it already imports the parsers.

@williamfzc williamfzc changed the title feat: add pnpm support WIP: feat: add pnpm support Aug 23, 2023
@williamfzc
Copy link
Copy Markdown
Author

williamfzc commented Aug 27, 2023

Hi @ba11b0y ,

PR for parsers (opensbom-generator/parsers#75) is finished. Tested with tool-python.

After it has been merged, I can start editing this PR for generator. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants