-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support PATCH calls from dev tools #10361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Craig Perkins <[email protected]>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Fixed both issues. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10361 +/- ##
==========================================
+ Coverage 60.28% 60.29% +0.01%
==========================================
Files 4454 4454
Lines 119245 119266 +21
Branches 19671 19679 +8
==========================================
+ Hits 71888 71915 +27
+ Misses 42372 42364 -8
- Partials 4985 4987 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone that has wished to create PATCH requests on the dev console, this is a huge win for our productivity - thanks for getting this done @cwperks
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
@cwperks do you have https://github.com/apps/opensearch-changeset-bot installed? that way to generate to changelog automatically? |
No, I don't have that installed. I will install it and update this PR. |
@kavilla re-ran the failing changelog check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwperks This is a great addition!🎉
I'll also submit a PR later today to update the CONTRIBUTING.md file to mention the bot and address #10044 |
@kavilla rebased this with main. Can you take another look at your earliest convenience? |
Description
This PR modifies the console plugin to allow PATCH calls from dev tools. The request parsing logic is updated to support reading array bodies which is common with PATCH calls.
Issues Resolved
resolves: #10105
resolves: #2343
Screenshot
Testing the changes
Log into Dev Tools and call a PATCH api. For example: https://docs.opensearch.org/latest/security/access-control/api/#patch-role-mapping
Changelog
Check List
yarn test:jest
yarn test:jest_integration