-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Trace Details code block scrollbar to scroll on edge #10651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matthew Ishii <[email protected]>
c389470
to
195b493
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10651 +/- ##
=======================================
Coverage 60.19% 60.19%
=======================================
Files 4434 4434
Lines 118671 118671
Branches 19503 19503
=======================================
Hits 71439 71439
Misses 42306 42306
Partials 4926 4926
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks for contribution!
Description
Trace Details page now has scrollbar that does not scroll in the middle of the code block
Issues Resolved
Screenshot
Before

After
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration