Skip to content

Conversation

mattishii26
Copy link
Contributor

@mattishii26 mattishii26 commented Oct 6, 2025

Description

Trace Details page now has scrollbar that does not scroll in the middle of the code block

Issues Resolved

Screenshot

Before
image (13)

After

image image image

Testing the changes

Changelog

  • fix: Traces code block scrollbar to scroll on edge

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to mattishii26/OpenSearch-Dashboards that referenced this pull request Oct 6, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.19%. Comparing base (48f0a70) to head (28454a2).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10651   +/-   ##
=======================================
  Coverage   60.19%   60.19%           
=======================================
  Files        4434     4434           
  Lines      118671   118671           
  Branches    19503    19503           
=======================================
  Hits        71439    71439           
  Misses      42306    42306           
  Partials     4926     4926           
Flag Coverage Δ
Linux_1 26.65% <ø> (ø)
Linux_2 38.83% <ø> (ø)
Linux_3 38.70% <ø> (+<0.01%) ⬆️
Linux_4 32.79% <ø> (ø)
Windows_1 26.66% <ø> (ø)
Windows_2 38.80% <ø> (ø)
Windows_3 38.70% <ø> (-0.01%) ⬇️
Windows_4 32.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@TackAdam TackAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks for contribution!

@TackAdam TackAdam added the OSD Changes being merged by the OSD team label Oct 8, 2025
@TackAdam TackAdam merged commit 27cb01b into opensearch-project:main Oct 9, 2025
223 of 228 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time-contributor OSD Changes being merged by the OSD team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants