Skip to content

Conversation

Maosaic
Copy link
Collaborator

@Maosaic Maosaic commented Oct 8, 2025

Description

Introduce a V2 dataset configurator that allow saving dataset when dataset creation.

Enable V2 dataset configurator in Explore

Issues Resolved

Screenshot

Screen.Recording.2025-10-08.at.3.34.49.PM.mp4

Testing the changes

Changelog

  • feat: Allow saving dataset from dataset configurator

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 57.03125% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.23%. Comparing base (27aecea) to head (e554ded).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../dataset_selector/configurator/configurator_v2.tsx 55.40% 21 Missing and 12 partials ⚠️
...s/data/public/ui/dataset_select/dataset_select.tsx 59.52% 12 Missing and 5 partials ⚠️
...ry/query_string/dataset_service/dataset_service.ts 70.00% 1 Missing and 2 partials ⚠️
...a/public/ui/dataset_selector/advanced_selector.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10690      +/-   ##
==========================================
+ Coverage   60.18%   60.23%   +0.05%     
==========================================
  Files        4444     4445       +1     
  Lines      118939   119031      +92     
  Branches    19585    19617      +32     
==========================================
+ Hits        71579    71698     +119     
+ Misses      42419    42367      -52     
- Partials     4941     4966      +25     
Flag Coverage Δ
Linux_1 26.60% <1.16%> (-0.03%) ⬇️
Linux_2 38.82% <ø> (-0.01%) ⬇️
Linux_3 38.79% <57.03%> (+0.11%) ⬆️
Linux_4 32.82% <1.16%> (-0.04%) ⬇️
Windows_1 26.61% <1.16%> (-0.03%) ⬇️
Windows_2 38.80% <ø> (-0.01%) ⬇️
Windows_3 38.79% <57.03%> (+0.11%) ⬆️
Windows_4 32.82% <1.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LDrago27
LDrago27 previously approved these changes Oct 9, 2025
Signed-off-by: Joey Liu <[email protected]>
@Maosaic Maosaic merged commit a25431e into opensearch-project:main Oct 9, 2025
131 of 134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor OSD Changes being merged by the OSD team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants