Skip to content

[Explore Vis]Feat/add bar gauge #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Explore Vis]Feat/add bar gauge #10697

wants to merge 4 commits into from

Conversation

Qxisylolo
Copy link
Contributor

Description

this pr adds bar gauge

Screenshot

2025-10-09.16.27.59.mov

Testing the changes

Changelog

  • feat: add bar gauge

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Qxisylolo
finish
c23ed04 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
add tests
cb4863d 
Signed-off-by: Qxisylolo <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.80645% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.20%. Comparing base (67890d6) to head (1f33027).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../components/visualizations/theme/default_colors.ts 6.66% 14 Missing ⚠️
...mponents/visualizations/bar_gauge/to_expression.ts 79.16% 0 Missing and 10 partials ⚠️
...visualizations/bar_gauge/bar_gauge_vis_options.tsx 76.47% 4 Missing ⚠️
...onents/visualizations/bar_gauge/bar_gauge_utils.ts 95.23% 0 Missing and 1 partial ⚠️
...ublic/components/visualizations/rule_repository.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10697      +/-   ##
==========================================
+ Coverage   60.18%   60.20%   +0.01%     
==========================================
  Files        4428     4449      +21     
  Lines      118504   119063     +559     
  Branches    19456    19621     +165     
==========================================
+ Hits        71320    71677     +357     
- Misses      42265    42437     +172     
- Partials     4919     4949      +30
Flag Coverage Δ
Linux_1 26.62% <ø> (-0.04%) ⬇️
Linux_2 38.82% <ø> (-0.01%) ⬇️
Linux_3 38.67% <ø> (-0.04%) ⬇️
Linux_4 32.92% <75.80%> (?)
Windows_1 26.63% <ø> (-0.04%) ⬇️
Windows_2 38.80% <ø> (-0.01%) ⬇️
Windows_3 38.68% <ø> (-0.04%) ⬇️
Windows_4 32.92% <75.80%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qxisylolo Qxisylolo marked this pull request as ready for review October 9, 2025 09:04
@Qxisylolo Qxisylolo changed the title [Explore vis]Feat/add bar gauge [Explore Vis]Feat/add bar gauge Oct 9, 2025
ruanyl
ruanyl reviewed Oct 11, 2025
View reviewed changes
src/plugins/explore/public/components/visualizations/bar/to_expression.ts
data: { values: transformedData },
layer: layers,
// Add legend configuration if needed, or explicitly set to null if disabled
legend: styles.addLegend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why this is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just cleaning, legend should be controlled by encoding.color, I cleaned some when I was doing global thresholds, I missed to clean this one.

src/plugins/explore/public/components/visualizations/bar_gauge/to_expression.ts
encoding: {
[`${symbolOpposite(styleOptions.exclusive.orientation, 'y')}`]: {
type: 'quantitative',
field: 'maxVal',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxVal of unfilled bar should take styleOptions.max into consider

src/plugins/explore/public/components/visualizations/theme/default_colors.ts

export const DEFAULT_GREY = '#d3d3d3';

export const getUnfilledArea = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this function to /bar_gauge because it's bar gauge specific

src/plugins/explore/public/components/visualizations/theme/default_colors.ts
return '#f1f1f1ff';
};

export const darkenColor = (hex: string, degree = 1) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't seem belong to theme folder, consider to move it to /utils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanyl ruanyl ruanyl left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

@Maosaic Maosaic Awaiting requested review from Maosaic Maosaic is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@d-buckner d-buckner Awaiting requested review from d-buckner d-buckner is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@TackAdam TackAdam Awaiting requested review from TackAdam TackAdam is a code owner

@ruchidh ruchidh Awaiting requested review from ruchidh ruchidh is a code owner

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy sumukhswamy is a code owner

@paulstn paulstn Awaiting requested review from paulstn paulstn is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

distinguished-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Qxisylolo @ruanyl