Upgrade rspack 2#11933
Conversation
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 0320b9b.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
❌ 2 Jest Test Failure(s)📄
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11933 +/- ##
===========================================
- Coverage 61.58% 0 -61.59%
===========================================
Files 4995 0 -4995
Lines 137542 0 -137542
Branches 23901 0 -23901
===========================================
- Hits 84707 0 -84707
+ Misses 46692 0 -46692
+ Partials 6143 0 -6143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| "@rsdoctor/rspack-plugin": "^1.3.11", | ||
| "@rspack/cli": "1.7.11", | ||
| "@rspack/core": "1.7.11", | ||
| "@rsdoctor/rspack-plugin": "^1.5.9", |
There was a problem hiding this comment.
The @rsdoctor/rspack-plugin 1.5.13 is in yarn.lock, so maybe it's better to put 1.5.13 here
| "@rspack/cli": "2.0.4", | ||
| "@rspack/core": "2.0.4", |
There was a problem hiding this comment.
The latest versions are 2.0.8 and according to release notes multiple fixes are provided, something to consider.
Disable import/no-unresolved for @rspack/core require
@rspack/core v2 is published as a pure ESM package ("type": "module"
with no CJS entry in exports). ESLint's import resolver cannot resolve
ESM-only packages in a require() context. Node.js 22 handles this at
runtime via native require(esm) support, so the import works correctly
despite the resolver limitation.
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Description
Update Rspack to v2
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration