fix(saved-objects): gate config import on advancedSettings.save capabilities#12220
Open
sumukhswamy wants to merge 1 commit into
Open
fix(saved-objects): gate config import on advancedSettings.save capabilities#12220sumukhswamy wants to merge 1 commit into
sumukhswamy wants to merge 1 commit into
Conversation
sumukhswamy
requested review from
AMoo-Miki,
FriedhelmWS,
LDrago27,
Maosaic,
Qxisylolo,
SuZhou-Joe,
TackAdam,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
d-buckner,
huyaboo,
joshuali925,
kavilla,
mengweieric,
paulstn,
ps48,
ruanyl,
ruchidh,
sejli,
virajsanghvi,
wanglam,
xinruiba,
yubonluo,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
sumukhswamy
force-pushed
the
fix/config-import-capability-check
branch
from
5868ba4 to
ce9a2c7
Compare
Contributor
✅ All Jest Tests PassedNo failures detected in JUnit reports. |
…ility The config type block introduced in opensearch-project#12014 (security fix for P432840841) rejected all config-type objects unconditionally and failed the entire import when any were present. This change: - Gates config import on the advancedSettings.save capability: admin users with this capability can import config objects; non-admin users still receive unsupported_type errors for config objects. - Changes from fail-all to filter-and-continue: when config objects are rejected, remaining valid objects in the same import are still processed. Config objects are reported as errors in the response alongside any successful imports. Resolves opensearch-project#12201 Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
force-pushed
the
fix/config-import-capability-check
branch
from
ce9a2c7 to
75e2761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The config type block introduced in #12014 (security fix for P432840841) rejected all config-type objects unconditionally and failed the entire import when any were present.
This change:
Issues Resolved
Resolves #12201
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration