test(discover): add unit tests for Pagination component#12263
Open
amarkdotdev wants to merge 1 commit into
Open
test(discover): add unit tests for Pagination component#12263amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
amarkdotdev
requested review from
AMoo-Miki,
LDrago27,
Maosaic,
Qxisylolo,
SuZhou-Joe,
TackAdam,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
d-buckner,
huyaboo,
joshuali925,
kavilla,
mengweieric,
paulstn,
ps48,
ruanyl,
ruchidh,
sejli,
sumukhswamy,
virajsanghvi,
wanglam,
xinruiba,
yubonluo,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
amarkdotdev
force-pushed
the
test/discover-pagination-coverage
branch
2 times, most recently
from
f7671e5 to
0a38bfa
Compare
Add unit tests for the previously untested Pagination component in the default_discover_table directory: - Renders pagination container with correct data-test-subj - Displays correct item range (startItem-endItem of totalItems) - Calls goToPage callback when a page button is clicked - Shows sample size limit warning when endItem >= sampleSize - Hides the warning when results are within the limit - Renders the correct number of page buttons This continues the test coverage work from opensearch-project#7048. Signed-off-by: Aaron Mark <64331623+amarkdotdev@users.noreply.github.com>
amarkdotdev
force-pushed
the
test/discover-pagination-coverage
branch
from
0a38bfa to
9068e93
Compare
Author
|
Same situation as #12261 — the Code-Diff-Analyzer failure is a workflow setup issue (unpinned GitHub Actions blocked by repo policy), not a problem with the Pagination unit tests. Retriggered CI with |
amarkdotdev
force-pushed
the
test/discover-pagination-coverage
branch
2 times, most recently
from
27fbf3a to
9068e93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the previously untested
Paginationcomponent insrc/plugins/discover/public/application/components/default_discover_table/.Tests added (6 tests)
data-test-subjgoToPagecallback with 0-indexed page numberendItem >= sampleSizeTesting
Related to #7048