Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial state on load #7591

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 30, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kawika Avilla <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.63%. Comparing base (5f19c37) to head (94461ed).
Report is 10 commits behind head on main.

Files Patch % Lines
.../public/ui/dataset_navigator/dataset_navigator.tsx 0.00% 11 Missing ⚠️
.../data/common/search/search_source/search_source.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7591      +/-   ##
==========================================
- Coverage   63.64%   63.63%   -0.02%     
==========================================
  Files        3629     3634       +5     
  Lines       79522    80115     +593     
  Branches    12604    12686      +82     
==========================================
+ Hits        50611    50979     +368     
- Misses      25842    26030     +188     
- Partials     3069     3106      +37     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.57% <0.00%> (-0.01%) ⬇️
Linux_3 40.57% <0.00%> (+0.35%) ⬆️
Linux_4 31.31% <0.00%> (-0.26%) ⬇️
Windows_1 30.57% <0.00%> (-0.21%) ⬇️
Windows_2 55.52% <0.00%> (-0.01%) ⬇️
Windows_3 40.57% <0.00%> (+0.33%) ⬆️
Windows_4 31.31% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla marked this pull request as draft July 30, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant