Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Security Lake data source in MDS plugin #7743

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goyamegh
Copy link
Contributor

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7743.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (ae7cfa6) to head (8ce1273).
Report is 23 commits behind head on main.

Files Patch % Lines
.../server/routes/data_source_connection_validator.ts 28.57% 3 Missing and 2 partials ⚠️
...bjects/data_source_saved_objects_client_wrapper.ts 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7743      +/-   ##
==========================================
- Coverage   63.82%   63.81%   -0.01%     
==========================================
  Files        3650     3658       +8     
  Lines       80966    81277     +311     
  Branches    12894    12969      +75     
==========================================
+ Hits        51673    51865     +192     
- Misses      26126    26225      +99     
- Partials     3167     3187      +20     
Flag Coverage Δ
Linux_1 30.14% <ø> (+0.10%) ⬆️
Linux_2 55.87% <ø> (+0.01%) ⬆️
Linux_3 ?
Linux_4 31.28% <ø> (-0.01%) ⬇️
Windows_1 30.16% <ø> (+0.10%) ⬆️
Windows_2 55.82% <ø> (+0.01%) ⬆️
Windows_3 40.40% <36.36%> (-0.01%) ⬇️
Windows_4 31.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant