-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discover] cached data structures TTL #8271
base: main
Are you sure you want to change the base?
[discover] cached data structures TTL #8271
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8271 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88833 88834 +1
Branches 13852 13853 +1
=======================================
+ Hits 56979 56980 +1
+ Misses 31239 31238 -1
- Partials 615 616 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If the dataset type config passes a meta object with `updateAt` within the data structure we know that the config opts into the TTL. If TTL over configuring UI setting then refetch in the case of S3 to get a new session ID in the cache. Signed-off-by: Kawika Avilla <[email protected]>
a8a2652
to
97e7425
Compare
description: i18n.translate('data.advancedSettings.query.cachedDataStructures.ttl', { | ||
defaultMessage: ` | ||
<strong>Experimental</strong>: | ||
Cached data structures TTL before refetching if the data type has it configured.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? Having HTML in text for description
?
Description
PR builds off of this PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8226/files
If the dataset type config passes a meta object with
updateAt
within the data structure we know that the config opts into the TTL.
If TTL over configuring UI setting then refetch in the case of S3
to get a new session ID in the cache.
Signed-off-by: Kawika Avilla [email protected]
Issues Partially Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration