Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto Suggest] PPL & SQL Value Suggestion #8275

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Auto Suggest] PPL & SQL Value Suggestion #8275

wants to merge 8 commits into from

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Sep 20, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.54545% with 47 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (f6924a7) to head (dd164a2).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ntlr/opensearch_ppl/opensearch_ppl_autocomplete.ts 0.00% 12 Missing ⚠️
...s/data/public/autocomplete/autocomplete_service.ts 0.00% 12 Missing ⚠️
...ata/public/antlr/opensearch_sql/code_completion.ts 0.00% 10 Missing ⚠️
...ata/public/antlr/opensearch_ppl/code_completion.ts 0.00% 9 Missing ⚠️
src/plugins/data/public/antlr/shared/utils.ts 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8275      +/-   ##
==========================================
- Coverage   64.14%   64.10%   -0.04%     
==========================================
  Files        3743     3743              
  Lines       88833    88836       +3     
  Branches    13852    13855       +3     
==========================================
- Hits        56979    56951      -28     
- Misses      31239    31270      +31     
  Partials      615      615
Flag Coverage Δ
Linux_1 30.06% <7.27%> (-0.01%) ⬇️
Linux_2 58.86% <ø> (ø)
Linux_4 31.58% <7.27%> (-0.01%) ⬇️
Windows_1 30.08% <7.27%> (-0.01%) ⬇️
Windows_2 58.81% <ø> (ø)
Windows_3 40.31% <14.54%> (-0.06%) ⬇️
Windows_4 31.58% <7.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn paulstn marked this pull request as ready for review September 23, 2024 16:44
sejli
sejli reviewed Sep 24, 2024
View reviewed changes
src/plugins/data/public/ui/query_editor/query_editor.tsx
@@ -285,6 +285,7 @@ export default class QueryEditorUI extends Component<Props, State> {
indexPattern,
position,
services: this.services,
dataset: this.queryString.getQuery().dataset,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pass dataset in here if services is already being passed in? It's already included in services if you use services.data.query.queryString.getQuery().dataset.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess a lot of the parameters can be removed if we can get querystring from services, let me see about that

src/plugins/data/public/antlr/shared/utils.ts
@@ -63,7 +65,7 @@ const fetchFromAPI = async (api: any, body: string) => {
export const fetchData = (
tables: string[],
queryFormatter: (table: string, dataSourceId?: string, title?: string) => any,
api: any,
http: any,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define http: HttpSetup

src/plugins/data/public/antlr/shared/utils.ts
tables: string[],
column: string,
services: IDataPluginServices,
dataset?: Dataset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is dataset optional here? Would it still work without it?

src/plugins/data/server/ui_settings.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these settings need to have the page reloaded? @kavilla

@kavilla kavilla added backport 2.x discover for discover reinvent labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent failed changeset valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulstn @sejli @kavilla