Fix Flaky Test RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction #16093
Conversation
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
>test-failure
kkewwei
force-pushed
the
fix_14304
branch
3 times, most recently
from
0c7405e
to
c29a7c1
Compare
|
❌ Gradle check result for c29a7c1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 250a33b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 99a1b04: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…StoreFetchMultiNodeMultiIndexesUsingBatchAction Signed-off-by: kkewwei <[email protected]>
|
❌ Gradle check result for c6058a6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| @@ -1366,7 +1366,8 @@ public void testSingleShardStoreFetchUsingBatchAction() throws ExecutionExceptio | |||
| DiscoveryNode[] nodes = getDiscoveryNodes(); | |||
| TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch response = prepareAndSendRequest( | |||
| new String[] { indexName }, | |||
| nodes | |||
| nodes, | |||
| false | |||
There was a problem hiding this comment.
Could you explain why this case doesn't need the index to be green?
There was a problem hiding this comment.
I have tested that if we don't define the number of nodes in the cluster, there will be one data node by default. The created index has 1 replicas, and never be green.
Description
In RecoveryFromGatewayIT test, the created indices may be not started yet, but is used immediately, which will cause unexpected exception. when it throws the exception, the scene is as follows:
Related Issues
Resolves #14304
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.