TimeSeries Desc Sort gets skipped with Lucene 10 upgrade #17329
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IdxSearcher Signed-off-by: expani <[email protected]>
Signed-off-by: expani <[email protected]>
expani
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
This is explains the |
|
@reta With this change, OS 2.19 and OS 3.0 are at same for following query types in big5 Without it, the latency for OS 3.0 was 10ms more than OS 2.19 |
|
❌ Gradle check result for 21d5903: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
{"run-benchmark-test": "id_4"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2634/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2634/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/43/
|
|
Some good improvements in sort and a few other range related queries. @expani |
|
❌ Gradle check result for 990c3bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: expani <[email protected]>
|
❌ Gradle check result for 0ce530b: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: expani <[email protected]>
|
❌ Gradle check result for 1757058: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 1757058: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: expani <[email protected]>
|
❌ Gradle check result for ccf11fb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 4ddd3fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17329 +/- ##
============================================
+ Coverage 72.40% 72.47% +0.07%
- Complexity 65828 65887 +59
============================================
Files 5316 5322 +6
Lines 305294 305477 +183
Branches 44289 44310 +21
============================================
+ Hits 221033 221399 +366
+ Misses 66187 65919 -268
- Partials 18074 18159 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msfroh
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We override
IndexSearcher#search(List<LeafReaderContext> leaves, Weight weight, Collector collector)and it contains the logic to apply time series desc optimisation for scanning segments in reverse for descending sort use-cases.Existing Lucene 9.12.1 and OS 2.19 call flow
Lucene 10.1.0 and OS 3.0 call flow
With Lucene 10 changes, the new replacement method
only gets invoked via
IndexSearcher#search(Query, CollecterManager)which is not used by OpenSearch inQueryPhase#searchWithCollector.So, it was never getting called causing the time series desc optimization to be skipped.
My changes ensure it will be called in the same way that IndexSearcher does for CollectorManager variant.
Related Issues
Resolves #17386