Add singleton optimization for DateHistogramAggregator #17643
+33
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 9c88ccd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
distribution/src/config/jvm.options
Outdated
| @@ -89,3 +89,5 @@ ${error.file} | |||
| # See please https://bugs.openjdk.org/browse/JDK-8341127 (openjdk/jdk#21283) | |||
| 23:-XX:CompileCommand=dontinline,java/lang/invoke/MethodHandle.setAsTypeCache | |||
| 23:-XX:CompileCommand=dontinline,java/lang/invoke/MethodHandle.asTypeUncached | |||
|
|
|||
| -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 | |||
There was a problem hiding this comment.
Should we have jvm debug port enabled by default? I think this will cause performance issues for production.
|
Hello! |
if you are expecting tangible performance improvements we recommend you to run a performance benchmark on your pull request, refer the README mentioned in the comment. Recommend you to use |
Signed-off-by: shreyah963 <[email protected]>
|
❌ Gradle check result for a1cade1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
{"run-benchmark-test": "id_4"} |
|
{"run-benchmark-test": "id_4"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2683/ . Final results will be published once the job is completed. |
|
{"run-benchmark-test": "id_3"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2685/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2683/
|
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2685/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/45/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/46/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimized the 'DateHistogramAggregator' to provide a specialized fast path for single-valued date fields. This optimization reduces method call overhead and eliminates unnecessary iteration logic when processing single values.
Key Changes
Single-Value Optimization
DocValues.unwrapSingleton()Before vs After Comparison
Before (Original Implementation):
After (Optimized Implementation):
Technical Details
Method Call Reduction:
advanceExact → docValueCount → nextValue → roundadvanceExact → longValueMemory Access Pattern:
Code Path Optimization:
Performance Impact
Backwards Compatibility
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.