Add skip_list param for date, scaled float and token count fields #19142
Conversation
|
❌ Gradle check result for 64cae12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for beb9dbe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 572b134: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 72c3c39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19142 +/- ##
============================================
- Coverage 72.84% 72.80% -0.04%
+ Complexity 69820 69818 -2
============================================
Files 5674 5674
Lines 320901 320925 +24
Branches 46394 46395 +1
============================================
- Hits 233751 233649 -102
- Misses 68269 68404 +135
+ Partials 18881 18872 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asimmahmood1
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale and
saratvemulapalli
as code owners
* follow up to opensearch-project#18889, which added to NumberFieldMapper * remaining are Boolean, which I'm not if its worth adding to * next step is to enable it by default, pending benchmark * update ScaledFloat testRangeQuery to apply same rounding logic to query as indexing to reduce the flakiness Signed-off-by: Asim Mahmood <[email protected]>
asimmahmood1
force-pushed
the
skiplist_scalledfloat
branch
from
183dde7 to
c2ab72a
Compare
|
❌ Gradle check result for c2ab72a: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1 similar comment
|
❌ Gradle check result for c2ab72a: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Search Project Board
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
github-project-automation
bot
moved this from Done
to In Progress
in Performance Roadmap
github-project-automation
bot
moved this from ✅ Done
to 🏗 In progress
in Search Project Board
|
❌ Gradle check result for c2ab72a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Search Project Board
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
github-project-automation
bot
moved this from ✅ Done
to 🏗 In progress
in Search Project Board
github-project-automation
bot
moved this from Done
to In Progress
in Performance Roadmap
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Search Project Board
asimmahmood1
changed the title
…ensearch-project#19142) Signed-off-by: Asim Mahmood <[email protected]>
3 participants
Description
Related Issues
Resolves [#17965]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.