-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix issue with updating core with a patch number other than 0 #19377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19377 +/- ##
============================================
+ Coverage 72.81% 72.94% +0.13%
- Complexity 69838 69849 +11
============================================
Files 5674 5674
Lines 320850 320861 +11
Branches 46383 46386 +3
============================================
+ Hits 233624 234058 +434
+ Misses 68361 67869 -492
- Partials 18865 18934 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
❌ Gradle check result for 891235b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 891235b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - time to rebase from main
I guess!
Description
While researching opensearch-project/opensearch-build#5720, I ran into an issue where I could not version bump the core to 3.3.1 and run
./gradlew localDistro
successfully. It would run into the following error:The reason for this is that it hit this block which is only triggered when the minor and patch version are both non-zero. When the patch number is 0 (as it is with any minor version bump) then the condition never gets triggered.
This PR resolves the issue by removing references to the Legacy ES version numbers which are more than 2 major versions in the past at this point.
Related Issues
Related to opensearch-project/opensearch-build#5720
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.