Skip to content

Conversation

Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented Oct 6, 2025

Description

Making Shard Limit Validator Index Tier Agnostic

Related Issues

Resolves #19610

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gagan6164 Gagan6164 requested a review from a team as a code owner October 6, 2025 11:08
Copy link
Contributor

github-actions bot commented Oct 6, 2025

❌ Gradle check result for 1f0f270: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 6, 2025

❌ Gradle check result for 9f7a68e: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 7, 2025

❌ Gradle check result for 53d5882: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gagan Singh Saini and others added 2 commits October 8, 2025 23:45
Copy link
Contributor

github-actions bot commented Oct 8, 2025

❌ Gradle check result for 85ebf51: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2025

✅ Gradle check result for 219bb74: SUCCESS

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.09%. Comparing base (39b7a59) to head (19efbd1).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...location/decider/ShardsLimitAllocationDecider.java 76.00% 4 Missing and 2 partials ⚠️
...va/org/opensearch/indices/ShardLimitValidator.java 90.76% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19532      +/-   ##
============================================
+ Coverage     73.00%   73.09%   +0.09%     
- Complexity    70534    70646     +112     
============================================
  Files          5719     5719              
  Lines        323260   323336      +76     
  Branches      46816    46828      +12     
============================================
+ Hits         235993   236356     +363     
+ Misses        68224    67937     -287     
  Partials      19043    19043              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gagan Singh Saini <[email protected]>
Copy link
Contributor

❌ Gradle check result for 83ea736: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots labels Oct 13, 2025
@Gagan6164 Gagan6164 force-pushed the remoteShardLimitValidator branch from 1c4f7b5 to 3d7d9de Compare October 13, 2025 12:06
Signed-off-by: Gagan Singh Saini <[email protected]>
@Gagan6164 Gagan6164 force-pushed the remoteShardLimitValidator branch from 1c4f7b5 to 19efbd1 Compare October 13, 2025 12:15
Copy link
Contributor

✅ Gradle check result for 19efbd1: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Making Shard Limit Validator and allocation decider index tier agnostic

2 participants