Introducing indexing & deletion strategy planner interfaces by shank9918 · Pull Request #20585 · opensearch-project/OpenSearch

shank9918 · 2026-02-10T12:09:21Z

Description

Introduce Strategy Planner Interfaces

Refactor indexing and deletion planning logic into dedicated planner interfaces responsible for primary and non-primary execution. Default planner implementations would encapsulate the existing InternalEngine behavior, while enabling alternative engines to provide custom planners or reuse shared implementations.

Delegate Planning via Composition

Update Engine implementations to delegate planning decisions to injected planner instances. The default behavior for InternalEngine should remain unchanged, ensuring backward compatibility.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

[Feature Request] Refactor Engine internals to decouple operation/result types and introduce pluggable planning strategies

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coderabbitai · 2026-02-10T12:09:33Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

server/src/main/java/org/opensearch/index/engine/Engine.java

github-actions · 2026-02-11T05:34:09Z

❌ Gradle check result for 944cf1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-02-11T06:03:45Z

❌ Gradle check result for 479e74f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/index/engine/DeletionStrategy.java

github-actions · 2026-02-11T07:56:35Z

❌ Gradle check result for eecb2d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-02-11T12:06:13Z

❌ Gradle check result for 6be6a79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-02-12T06:51:41Z

❌ Gradle check result for 83bcfc7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-02-12T08:49:25Z

❌ Gradle check result for 83bcfc7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/index/engine/InternalEngine.java

server/src/main/java/org/opensearch/index/engine/DeletionStrategy.java

Bukhtawar

Thanks for the changes, left minor comment, lets tease out Strategy classes into a dedicated Java package

server/src/main/java/org/opensearch/index/engine/DeletionStrategyPlanner.java

shank9918 · 2026-02-26T05:08:24Z

Thanks for the changes, left minor comment, lets tease out Strategy classes into a dedicated Java package

The Planner classes rely on the package-private LiveVersionMap and VersionValue. Relocating strategy and planner classes to a dedicated package would force us to modify their access levels which I want to avoid.

server/src/main/java/org/opensearch/index/engine/InternalEngine.java

github-actions · 2026-02-26T07:38:31Z

Persistent review updated to latest commit 2c61040

server/src/main/java/org/opensearch/index/engine/OperationStrategyPlanner.java

github-actions · 2026-02-26T08:05:20Z

Persistent review updated to latest commit 135ed2c

server/src/main/java/org/opensearch/index/engine/IndexingStrategyPlanner.java

server/src/main/java/org/opensearch/index/engine/DeletionStrategyPlanner.java

github-actions · 2026-02-26T08:12:36Z

Persistent review updated to latest commit 614ddcb

github-actions · 2026-02-26T09:45:01Z

✅ Gradle check result for 614ddcb: SUCCESS

github-actions · 2026-02-26T16:40:38Z

Persistent review updated to latest commit cf08e29

server/src/main/java/org/opensearch/index/engine/InternalEngine.java

github-actions · 2026-02-26T17:13:12Z

Persistent review updated to latest commit a681e1e

Signed-off-by: Shashank Gowri <shnkgo@amazon.com>

github-actions · 2026-02-26T17:31:37Z

Persistent review updated to latest commit 22e6d16

github-actions · 2026-02-26T17:45:31Z

❌ Gradle check result for 22e6d16: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shank9918 changed the title ~~Introducing indexing & deletion strategy planner interfaces and refac…~~ Decouple operation/result types and introduce pluggable planning strategies Feb 10, 2026

mgodwan reviewed Feb 10, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/Engine.java Outdated Show resolved Hide resolved

shank9918 force-pushed the refactored-engine branch 3 times, most recently from 344f4b8 to 944cf1a Compare February 11, 2026 05:26

shank9918 force-pushed the refactored-engine branch 3 times, most recently from 9513ca5 to 479e74f Compare February 11, 2026 05:49

shank9918 force-pushed the refactored-engine branch from 479e74f to eecb2d0 Compare February 11, 2026 06:12

Bukhtawar reviewed Feb 11, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/DeletionStrategy.java Outdated Show resolved Hide resolved

shank9918 changed the title ~~Decouple operation/result types and introduce pluggable planning strategies~~ Introducing indexing & deletion strategy planner interfaces Feb 11, 2026

shank9918 force-pushed the refactored-engine branch from eecb2d0 to 6be6a79 Compare February 11, 2026 11:35

shank9918 force-pushed the refactored-engine branch 2 times, most recently from 3c3a9cd to 83bcfc7 Compare February 12, 2026 06:05

shank9918 closed this Feb 12, 2026

shank9918 reopened this Feb 12, 2026

shank9918 requested review from a team, saratvemulapalli, shwetathareja and sohami as code owners February 25, 2026 05:26

Bukhtawar reviewed Feb 25, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/InternalEngine.java Show resolved Hide resolved

Bukhtawar reviewed Feb 25, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/DeletionStrategy.java Show resolved Hide resolved

Bukhtawar reviewed Feb 25, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/DeletionStrategy.java Show resolved Hide resolved

Bukhtawar reviewed Feb 25, 2026

View reviewed changes

mgodwan reviewed Feb 25, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/DeletionStrategyPlanner.java Outdated Show resolved Hide resolved

server/src/main/java/org/opensearch/index/engine/DeletionStrategyPlanner.java Outdated Show resolved Hide resolved

mgodwan reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/InternalEngine.java Show resolved Hide resolved

shank9918 force-pushed the refactored-engine branch from 187b95f to 2c61040 Compare February 26, 2026 07:37

Bukhtawar reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/OperationStrategyPlanner.java Outdated Show resolved Hide resolved

Bukhtawar reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/OperationStrategyPlanner.java Outdated Show resolved Hide resolved

Bukhtawar reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/OperationStrategyPlanner.java Outdated Show resolved Hide resolved

Bukhtawar reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/IndexingStrategyPlanner.java Outdated Show resolved Hide resolved

server/src/main/java/org/opensearch/index/engine/DeletionStrategyPlanner.java Outdated Show resolved Hide resolved

shank9918 force-pushed the refactored-engine branch from 614ddcb to cf08e29 Compare February 26, 2026 16:39

mgodwan reviewed Feb 26, 2026

View reviewed changes

server/src/main/java/org/opensearch/index/engine/InternalEngine.java Show resolved Hide resolved

shank9918 force-pushed the refactored-engine branch from cf08e29 to a681e1e Compare February 26, 2026 17:11

Bukhtawar approved these changes Feb 26, 2026

View reviewed changes

Introducing indexing & deletion strategy planner interfaces

22e6d16

Signed-off-by: Shashank Gowri <shnkgo@amazon.com>

shank9918 force-pushed the refactored-engine branch from a681e1e to 22e6d16 Compare February 26, 2026 17:29

Conversation

shank9918 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

coderabbitai bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bukhtawar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shank9918 commented Feb 26, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shank9918 commented Feb 10, 2026 •

edited

Loading

coderabbitai bot commented Feb 10, 2026 •

edited

Loading