-
Notifications
You must be signed in to change notification settings - Fork 81
Adding skip-changelog to all depandabot PRs #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Amit Galitzky <[email protected]>
d39da35
to
dedaae2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
============================================
- Coverage 81.59% 81.59% -0.01%
+ Complexity 6039 6038 -1
============================================
Files 536 536
Lines 24427 24427
Branches 2494 2494
============================================
- Hits 19932 19931 -1
Misses 3260 3260
- Partials 1235 1236 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FYI Many repos have a separate dependabot workflow to add CHANGELOG entries directly on dependabot PRs. Its got the same inconveniences of having to manually resolve conflicts in the CHANGELOG though so the changes in this may be a better approach if the new Release Notes generation can handle missing changelog entries from the git log. See the dependabt_pr.yml workflow from the security repo for example. |
@peterzhuamazon @gaiksaya Will the new automatic release notes generated be able to identify missing entries in the CHANGELOG and add them automatically? For instance with dependabot PRs is it ok to skip CHANGELOG entries and the automation will work ok? |
Currently the automation first looks for CHANGELOG and uses the same to generate release notes, if not found it then fall backs on to commit history to go through each commit and process it, if an entry is missed from CHANGELOG, it will not be picked up by automation. |
Description
Adding skip-changelog label to all depandabot PRs
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.