Skip to content

Conversation

amitgalitz
Copy link
Member

Description

Adding skip-changelog label to all depandabot PRs

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.59%. Comparing base (17e56f0) to head (dedaae2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1556      +/-   ##
============================================
- Coverage     81.59%   81.59%   -0.01%     
+ Complexity     6039     6038       -1     
============================================
  Files           536      536              
  Lines         24427    24427              
  Branches       2494     2494              
============================================
- Hits          19932    19931       -1     
  Misses         3260     3260              
- Partials       1235     1236       +1     
Flag Coverage Δ
plugin 81.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks
Copy link
Member

cwperks commented Aug 25, 2025

FYI Many repos have a separate dependabot workflow to add CHANGELOG entries directly on dependabot PRs.

Its got the same inconveniences of having to manually resolve conflicts in the CHANGELOG though so the changes in this may be a better approach if the new Release Notes generation can handle missing changelog entries from the git log.

See the dependabt_pr.yml workflow from the security repo for example.

@cwperks
Copy link
Member

cwperks commented Aug 25, 2025

@peterzhuamazon @gaiksaya Will the new automatic release notes generated be able to identify missing entries in the CHANGELOG and add them automatically? For instance with dependabot PRs is it ok to skip CHANGELOG entries and the automation will work ok?

@rishabh6788
Copy link

@peterzhuamazon @gaiksaya Will the new automatic release notes generated be able to identify missing entries in the CHANGELOG and add them automatically? For instance with dependabot PRs is it ok to skip CHANGELOG entries and the automation will work ok?

Currently the automation first looks for CHANGELOG and uses the same to generate release notes, if not found it then fall backs on to commit history to go through each commit and process it, if an entry is missed from CHANGELOG, it will not be picked up by automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants