Skip to content

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Oct 1, 2025

Description

Security plugin is adding a list setting to allow individually specify which resources should be marked as protected after onboarding. This PR supports onboarding of AD to that list setting.
opensearch-project/security#5671

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (b176abe) to head (221e184).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsearch/timeseries/transport/GetConfigRequest.java 0.00% 3 Missing ⚠️
...rg/opensearch/timeseries/transport/JobRequest.java 0.00% 3 Missing ⚠️
...arch/timeseries/transport/DeleteConfigRequest.java 33.33% 1 Missing and 1 partial ⚠️
...arch/ad/transport/IndexAnomalyDetectorRequest.java 0.00% 1 Missing ⚠️
...ch/ad/transport/PreviewAnomalyDetectorRequest.java 0.00% 1 Missing ⚠️
...rch/forecast/transport/IndexForecasterRequest.java 0.00% 1 Missing ⚠️
...imeseries/transport/SuggestConfigParamRequest.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1566      +/-   ##
============================================
- Coverage     81.47%   81.40%   -0.08%     
+ Complexity     6136     6132       -4     
============================================
  Files           542      542              
  Lines         24885    24898      +13     
  Branches       2540     2540              
============================================
- Hits          20275    20268       -7     
- Misses         3342     3364      +22     
+ Partials       1268     1266       -2     
Flag Coverage Δ
plugin 81.40% <7.69%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...arch/ad/transport/IndexAnomalyDetectorRequest.java 94.44% <0.00%> (-1.79%) ⬇️
...ch/ad/transport/PreviewAnomalyDetectorRequest.java 88.46% <0.00%> (-3.54%) ⬇️
...rch/forecast/transport/IndexForecasterRequest.java 46.29% <0.00%> (-0.88%) ⬇️
...imeseries/transport/SuggestConfigParamRequest.java 87.50% <0.00%> (-2.83%) ⬇️
...arch/timeseries/transport/DeleteConfigRequest.java 81.81% <33.33%> (-7.66%) ⬇️
...nsearch/timeseries/transport/GetConfigRequest.java 77.96% <0.00%> (-4.18%) ⬇️
...rg/opensearch/timeseries/transport/JobRequest.java 86.48% <0.00%> (-7.64%) ⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaituo kaituo merged commit 50dc005 into opensearch-project:main Oct 1, 2025
19 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants