-
Notifications
You must be signed in to change notification settings - Fork 11
Combine bubble up and log sequence as one component #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
s-zx
wants to merge
5
commits into
opensearch-project:main
Choose a base branch
from
s-zx:feat/combine-bubbleUp-logPattern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Combine bubble up and log sequence as one component #117
s-zx
wants to merge
5
commits into
opensearch-project:main
from
s-zx:feat/combine-bubbleUp-logPattern
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 64.78% 63.92% -0.87%
==========================================
Files 57 57
Lines 1806 1857 +51
Branches 434 463 +29
==========================================
+ Hits 1170 1187 +17
- Misses 634 667 +33
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Zhenxing Shen <[email protected]>
Signed-off-by: Zhenxing Shen <[email protected]>
Signed-off-by: Zhenxing Shen <[email protected]>
ebc180c
to
e4e7ac6
Compare
Hailong-am
reviewed
Sep 30, 2025
yubonluo
reviewed
Sep 30, 2025
public/components/notebooks/components/data_distribution/hooks/use_data_distribution.ts
Show resolved
Hide resolved
yubonluo
reviewed
Sep 30, 2025
Thanks @s-zx , Good refactor! |
Signed-off-by: Zhenxing Shen <[email protected]>
yubonluo
approved these changes
Sep 30, 2025
Hailong-am
approved these changes
Sep 30, 2025
@s-zx can you help to check CI failure
|
Sure, I will check. |
Signed-off-by: Zhenxing Shen <[email protected]>
FriedhelmWS
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Agentic Notebook] Combine bubble up and log sequence as one component and expose it as reusable components
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.