Skip to content

Conversation

s-zx
Copy link
Contributor

@s-zx s-zx commented Sep 12, 2025

Description

[Agentic Notebook] Combine bubble up and log sequence as one component and expose it as reusable components

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.92%. Comparing base (8d1f04e) to head (c24dd43).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   64.78%   63.92%   -0.87%     
==========================================
  Files          57       57              
  Lines        1806     1857      +51     
  Branches      434      463      +29     
==========================================
+ Hits         1170     1187      +17     
- Misses        634      667      +33     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@s-zx s-zx marked this pull request as ready for review September 16, 2025 07:30
Signed-off-by: Zhenxing Shen <[email protected]>
Signed-off-by: Zhenxing Shen <[email protected]>
@s-zx s-zx force-pushed the feat/combine-bubbleUp-logPattern branch from ebc180c to e4e7ac6 Compare September 18, 2025 06:24
@s-zx s-zx requested a review from Hailong-am as a code owner September 18, 2025 06:24
@yubonluo
Copy link
Contributor

Thanks @s-zx , Good refactor!

@Hailong-am
Copy link
Collaborator

@s-zx can you help to check CI failure

ERROR in ./public/plugin.tsx
         │          Module not found: Error: Can't resolve './components/notebooks/components/combined_analysis' in '/home/runner/work/dashboards-investigation/dashboards-investigation/OpenSearch-Dashboards/plugins/dashboards-investigation/public'
         │          resolve './components/notebooks/components/combined_analysis' in '/home/runner/work/dashboards-investigation/dashboards-investigation/OpenSearch-Dashboards/plugins/dashboards-investigation/public'```

@s-zx
Copy link
Contributor Author

s-zx commented Oct 9, 2025

@s-zx can you help to check CI failure

ERROR in ./public/plugin.tsx
         │          Module not found: Error: Can't resolve './components/notebooks/components/combined_analysis' in '/home/runner/work/dashboards-investigation/dashboards-investigation/OpenSearch-Dashboards/plugins/dashboards-investigation/public'
         │          resolve './components/notebooks/components/combined_analysis' in '/home/runner/work/dashboards-investigation/dashboards-investigation/OpenSearch-Dashboards/plugins/dashboards-investigation/public'```

Sure, I will check.

Signed-off-by: Zhenxing Shen <[email protected]>
@s-zx s-zx requested a review from FriedhelmWS as a code owner October 9, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants