KCL metrics management through config #6361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RashmiRam
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
requested changes
Jan 12, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thank you @RashmiRam for this contribution. I have one comment.
Also, the DCO is failing. Please see the failing build for information and instructions on how to fix: https://github.com/opensearch-project/data-prepper/pull/6361/checks?check_run_id=58389994642
|
|
||
| @Getter | ||
| @JsonProperty("metrics") | ||
| private boolean metrics = false; |
Member
There was a problem hiding this comment.
The existing configuration appears to include these metrics. So we must make the default consistent with the current behavior.
Also, we should express this as disabling rather than enabling. And we should clarify what metrics are disabled. There are more than KCL metrics, so the current name can be confusing.
I propose this configuration:
disable_client_metrics: true
or
disable_kcl_metrics: true
1.Added "metrics" config to disable/enable sending KCL metrics to cloudwatch 2.Default value is false. Signed-off-by: RashmiRam <[email protected]>
Signed-off-by: RashmiRam <[email protected]>
RashmiRam
force-pushed
the
kinesis-source-metrics-config
branch
from
dea83ca to
2a54f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Added "metrics" config to disable/enable sending KCL metrics to cloudwatch
2.Default value is false.
Issues Resolved
Resolves #6360
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.