-
Notifications
You must be signed in to change notification settings - Fork 616
Note that grok ingest processor patterns are not anchored #11182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Note that grok ingest processor patterns are not anchored #11182
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Would it be appropriate to also update the examples to illustrate the recommendation? @kolchfa-aws |
@hackery Thanks for this docs addition! Yes, it would be very helpful to include examples if you can. |
@gaobinlong Could you review this PR? |
@hackery Thanks! Could you fix DCO please? |
Oh I see, the DCO check isn't recognising the local Sign-off - sure, will fix. |
Signed-off-by: James Beckett <[email protected]>
Signed-off-by: James Beckett <[email protected]>
318a637
to
feac586
Compare
@kolchfa-aws do I need to do something else to let this pass checks/approval etc? |
We just need this PR tech reviewed and then we can do a doc/editorial review and merge. |
Description
Make docs explicit that patterns are not anchored, with advice to do so for performance.
Issues Resolved
None
Version
All
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.