Skip to content

Conversation

hackery
Copy link

@hackery hackery commented Oct 3, 2025

Description

Make docs explicit that patterns are not anchored, with advice to do so for performance.

Issues Resolved

None

Version

All

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Oct 3, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hackery
Copy link
Author

hackery commented Oct 3, 2025

Would it be appropriate to also update the examples to illustrate the recommendation? @kolchfa-aws

@kolchfa-aws
Copy link
Collaborator

@hackery Thanks for this docs addition! Yes, it would be very helpful to include examples if you can.

@kolchfa-aws
Copy link
Collaborator

@gaobinlong Could you review this PR?

@kolchfa-aws
Copy link
Collaborator

@hackery Thanks! Could you fix DCO please?

@kolchfa-aws kolchfa-aws added Tech review PR: Tech review in progress backport 3.2 labels Oct 6, 2025
@hackery
Copy link
Author

hackery commented Oct 6, 2025

Oh I see, the DCO check isn't recognising the local Sign-off - sure, will fix.

@hackery hackery force-pushed the ingest-processor-grok-regex-anchoring branch from 318a637 to feac586 Compare October 6, 2025 19:35
@hackery
Copy link
Author

hackery commented Oct 13, 2025

@kolchfa-aws do I need to do something else to let this pass checks/approval etc?

@kolchfa-aws
Copy link
Collaborator

@kolchfa-aws do I need to do something else to let this pass checks/approval etc?

We just need this PR tech reviewed and then we can do a doc/editorial review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.2 Tech review PR: Tech review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants