Skip to content

Add new attributes field to ToolStep #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

dbwiddis
Copy link
Member

Description

Adds the new (optional) "attributes" map to the MLToolSpec in the ToolStep.

Related Issues

Fixes #1112

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Apr 16, 2025
@dbwiddis dbwiddis removed the backport 2.x backport PRs to 2.x branch label Apr 16, 2025
@dbwiddis
Copy link
Member Author

@pyek-bot can you do a quick review here?

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (56b372c) to head (99401da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1113      +/-   ##
============================================
+ Coverage     77.29%   77.30%   +0.01%     
- Complexity     1093     1094       +1     
============================================
  Files           101      101              
  Lines          5302     5305       +3     
  Branches        509      510       +1     
============================================
+ Hits           4098     4101       +3     
  Misses          954      954              
  Partials        250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbwiddis dbwiddis merged commit f8923ab into opensearch-project:main Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ToolStep does not include new fields for MLToolSpec
4 participants