Add Convert index to remote support for dashboard ism plugin - #1373
Open
wntmddus wants to merge 3 commits into
Open
Add Convert index to remote support for dashboard ism plugin#1373wntmddus wants to merge 3 commits into
wntmddus wants to merge 3 commits into
Conversation
Signed-off-by: Seung Yeon Joo <seung.yeon.joo@oracle.com>
wntmddus
requested review from
Hailong-am,
RamakrishnaChilaka,
SuZhou-Joe,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
November 5, 2025 20:54
|
hello @wntmddus I did not see this PR and created a new one (#1406) based on #1319 that was on hold for about 10 months. Of course there is no need for 2 PRs that are handing the same :) I can close mine as yours has more tests to it. However I can see you've added options that are not yet available in the ism backend plugin but you're missing |
1 task
Signed-off-by: Seung Yeon Joo <seung.yeon.joo@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds dashboard support for the new
convert_index_to_remoteaction options.This updates the visual policy editor to support:
include_aliasesignore_index_settingsnumber_of_replicasdelete_original_indexrename_patternAlso updates the action model, default action config, sample policy fixture, and tests.
Notable behavior:
number_of_replicasis optional. Leaving it empty omits the field so the restored remote index inherits the snapshot setting.rename_patterndefaults to$1_remote.rename_patternmust be non-empty and contain$1.number_of_replicasmust be non-negative when specified.